New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parser] Enable "exportNamespaceFrom" by default #10521
Conversation
@@ -106,7 +106,7 @@ export type ParserPlugin = | |||
'dynamicImport' | | |||
'estree' | | |||
'exportDefaultFrom' | | |||
'exportNamespaceFrom' | | |||
'exportNamespaceFrom' | // deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if a /** @deprecated */
annotation preceding the literal would work, or if it only works with enums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also remove exportNamespaceFrom.syntax
on packages/babel-core/src/transformation/util/missing-plugin-helper.js
?
No, it's otherwise people using new |
It has been merged to the main spec: tc39/ecma262#1174